-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bio] Update biomed property embeddings. #4721
Conversation
Adds: - mechanismOfAction - hgncID - inChIKey Updates: - unifiedMedicalLanguageSystemConceptUniqueIdentifier -> umlsConceptUniqueID - ncbiTaxonID->ncbiTaxId, - referenceAlleleNCBI -> referenceAllele - genomicCoordinates -> hasGenomicCoordinates Deletes: - diseaseName - observedAllele - hg19GenomicPosition - hg19GenomicLocation - hg38GenomicPosition - hg38GenomicLocation - hasRNATranscript - ncbiDNASequenceName - imageUrl - availableStrength Example: (mechanismOfAction](https://screenshot.googleplex.com/BUyvhKHv7AZuMwF)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chejennifer I'm not sure why we're seeing this diff. I'm removing the hasRNATranscript
property which is related to the query, but I don't know why it's affecting entity recognition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, the reason for this is we used to be reading the entity from the context (from the previous query), but we will only read from context if at least one of entity or property is detected in the current query. Since now, no property is detected, we won't use the context and no entity gets returned. We actually should remove this query from the tests since this isn't really testing anything anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, the reason for this is we used to be reading the entity from the context (from the previous query), but we will only read from context if at least one of entity or property is detected in the current query. Since now, no property is detected, we won't use the context and no entity gets returned. We actually should remove this query from the tests since this isn't really testing anything anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding!
Adds:
Updates:
Deletes:
Example Screenshots